client/fingerprint: add digitalocean fingerprinter #12015
Conversation
| return "", err | ||
| } else if res.StatusCode != http.StatusOK { | ||
| f.logger.Debug("could not read value for attribute", "attribute", attribute, "resp_code", res.StatusCode) | ||
| return "", err |
There was a problem hiding this comment.
This error could be nil; its value is unrelated to the status code
There was a problem hiding this comment.
I moved this branch lower in the function to include the resp body in the error message. Not 100% sure if this is safe (i.e. will digitalocean always return some body with an error response), but it would improve debugability if it does work
There was a problem hiding this comment.
Hi @kevinschoonover thanks for the PR! As a DO user myself I'm happy to see this.
I just had a handful of style/convention nitpicks and the one status code err return, if you don't mind taking a look.
shoenig
added
theme/fingerprint
type/enhancement
stage/accepted
Co-authored-by: Seth Hoenig <[email protected]>
|
@shoenig thanks for the comments and fast review time! updated the PR to address the concerns. Can you double check my rationale for https://github.com/hashicorp/nomad/pull/12015/files#diff-a213a911b1884870d57540bf67b3dfd2f99f108478e8a930ed42153569e55086R92-R95. I believe digitalocean will return a body with any error message which should make debugging this cleaner, but it may be confusing if the user gets a 500 error and then the code path actually errors out reading the body https://github.com/hashicorp/nomad/pull/12015/files#diff-a213a911b1884870d57540bf67b3dfd2f99f108478e8a930ed42153569e55086R87-R90 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
adds fingerprinter for DigitalOcean droplets using the DigitalOcean Metadata api.
screenshot of it working on a droplet:
