Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix up very long tag word breaking the allocation service table width #11995

Merged

Conversation

ttys3
Copy link
Contributor

@ttys3 ttys3 commented Feb 3, 2022

for service like traefik, it is easy to break the table ui when specific a middleware config like basic auth.

ref https://doc.traefik.io/traefik/middlewares/http/basicauth/ an example consul catalog tags look like this:

traefik.http.middlewares.test-auth.basicauth.users=test:$apr1$H6uskkkW$IgXLP6ewTrSuBkTrqE8wj/,test2:$apr1$d9hr9HBB$4HxwgUir3HP4EsggP/QNo0

image

with word break css enbled:

image

@vercel vercel bot temporarily deployed to Preview – nomad February 3, 2022 15:18 Inactive
@ttys3 ttys3 changed the title style: fix up very long word breaking the table width style: fix up very long word breaking the allocation service table width Feb 3, 2022
@ttys3 ttys3 changed the title style: fix up very long word breaking the allocation service table width style: fix up very long tag word breaking the allocation service table width Feb 3, 2022
@ttys3 ttys3 force-pushed the fix-allocation-overview-services-tags-break-ui branch from 1909d1b to eba250b Compare February 3, 2022 15:29
@vercel vercel bot temporarily deployed to Preview – nomad February 3, 2022 15:29 Inactive
@ttys3 ttys3 force-pushed the fix-allocation-overview-services-tags-break-ui branch from eba250b to 07ea634 Compare February 3, 2022 15:34
@vercel vercel bot temporarily deployed to Preview – nomad February 3, 2022 15:34 Inactive
@ttys3 ttys3 force-pushed the fix-allocation-overview-services-tags-break-ui branch from 07ea634 to 363ffb2 Compare February 3, 2022 15:37
@vercel vercel bot temporarily deployed to Preview – nomad February 3, 2022 15:37 Inactive
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ttys3!

I pushed a couple of commits to organize the code a bit and make the new class name match the existing ones. I also added a CHANGELOG entry for this.

@lgfa29 lgfa29 merged commit 3fc7389 into hashicorp:main Feb 5, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants