Reuse blocked evaluations and handle unblock events that occurred during scheduling #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
force-pushed
the
f-lighter-blocked-evals
branch
from
84fb757 to
c7b7a9b
Compare
…an update while in the scheduler
dadgar
force-pushed
the
f-lighter-blocked-evals
branch
from
c7b7a9b to
8456f77
Compare
| @@ -133,6 +146,14 @@ func (b *BlockedEvals) Block(eval *structs.Evaluation) { | |||
| return | |||
| } | |||
|
|
|||
| // Check if the eval missed an unblock while it was in the scheduler at an | |||
| // older index. | |||
There was a problem hiding this comment.
I would add some more comment as to how/why this is possible. "The scheduler could have been invoked with a snapshot of state that was prior to additional capacity being added or allocations becoming terminal."
|
LGTM |
dadgar
force-pushed
the
f-lighter-blocked-evals
branch
from
fb804d7 to
230b663
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@armon for review. Should be reviewed after #1188 is merged and this rebased.