Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct task row memory unit #11980

Merged
merged 3 commits into from
Feb 2, 2022
Merged

correct task row memory unit #11980

merged 3 commits into from
Feb 2, 2022

Conversation

ttys3
Copy link
Contributor

@ttys3 ttys3 commented Feb 2, 2022 •
edited by lgfa29
Loading

correct task row memory unit

Closes #10499

@vercel vercel bot temporarily deployed to Preview – nomad February 2, 2022 13:47 Inactive
lgfa29
lgfa29 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @ttys3!

Looking at the code I noticed that this component was also using the wrong unit formatter as well, so I push a commit to fix that too (and also a changelog entry).

@lgfa29 lgfa29 merged commit 09e68d1 into hashicorp:main Feb 2, 2022
@lgfa29 lgfa29 added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line labels Apr 19, 2022
This was referenced Apr 19, 2022
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: Task row memory progress chart misreports denominator units
2 participants
@ttys3 @lgfa29