core: prevent malformed plans from crashing leader #11944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
approved these changes
Jan 27, 2022
|
|
||
| // TestPlanSubmitEndpoint_Bad asserts that the Plan.Submit endpoint rejects bad data | ||
| // with an error instead of panicking. | ||
| func TestPlanEndpoint_Submit_Bad(t *testing.T) { |
There was a problem hiding this comment.
I like the name, strong and to the point.
There was a problem hiding this comment.
Ha, you made me notice I typo'd it in the comment. Thanks 😁
schmichael
force-pushed
the
b-validate-plan
branch
from
28fb4b5 to
f88fe78
Compare
The Plan.Submit endpoint assumed PlanRequest.Plan was never nil. While there is no evidence it ever has been nil, we should not panic if a nil plan is ever submitted because that would crash the leader.
schmichael
force-pushed
the
b-validate-plan
branch
from
f88fe78 to
1e39c32
Compare
lgfa29
added a commit
that referenced
this pull request
Apr 14, 2022
lgfa29
added
backport/1.1.x
This was referenced Apr 19, 2022
lgfa29
added a commit
that referenced
this pull request
Apr 19, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Plan.Submit endpoint assumed PlanRequest.Plan was never nil. While
there is no evidence it ever has been nil, we should not panic if a nil
plan is ever submitted because that would crash the leader.