Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #11884: Move volume link to the source column and fix the link target #11896

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Fix for #11884: Move volume link to the source column and fix the link target #11896

merged 2 commits into from
Jan 26, 2022

Conversation

NomAnor
Copy link
Contributor

@NomAnor NomAnor commented Jan 21, 2022

This fixes the wrong link target in the volumes list of tasks. I moved the link to the source column which is the actual link target.

@NomAnor
Move volume link to the source column and fix the link target
3222ede 
The link target used the volume name instead of the volume id.

Fixes issue hashicorp#11884.
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – nomad January 21, 2022 12:03 Inactive
@tgross
Copy link
Member

tgross commented Jan 24, 2022

@ChaiWithJai this patch effectively changes the task index page to look like the following (the top row is a CSI volume and the bottom row is a host volume). I'm ok with this from a technical standpoint and it makes a lot more sense to me to have the link from the real source object, but I wanted to run it by you from a design standpoint before pressing the Big Green Merge Button 😀

Screen Shot 2022-01-24 at 11 00 55 AM

tgross
tgross approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross requested a review from ChaiWithJai January 24, 2022 16:03
ChaiWithJai
ChaiWithJai approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross added this to the 1.3.0 milestone Jan 26, 2022
@vercel vercel bot temporarily deployed to Preview – nomad January 26, 2022 18:43 Inactive
@tgross
Copy link
Member

tgross commented Jan 26, 2022

I've added a changelog entry and will merge once CI is green. Thanks @NomAnor!

@tgross tgross merged commit 045bcd7 into hashicorp:main Jan 26, 2022
This was referenced Jan 26, 2022
Closed
Closed
@lgfa29 lgfa29 added stage/needs-backporting backport/1.1.x backport to 1.1.x release line labels Apr 14, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Apr 19, 2022
Merged
@lgfa29 lgfa29 added the backport/1.2.x backport to 1.1.x release line label Apr 19, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Apr 19, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@NomAnor @hashicorp-cla @tgross @ChaiWithJai @lgfa29