Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client APIs for reporting resource usage of host and allocations #1189

Merged
merged 69 commits into from
May 31, 2016

Conversation

diptanu
Copy link
Contributor

@diptanu diptanu commented May 19, 2016

No description provided.

@diptanu diptanu force-pushed the f-alloc-resource-usage branch 6 times, most recently from 35b6f9a to aa11fe8 Compare May 22, 2016 23:19
if node.HTTPAddr == "" {
return nil, fmt.Errorf("http addr of the node where alloc %q is running is not advertised", alloc.ID)
}
u := &url.URL{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you use the helpers that the rest of the package uses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dadgar Are you talking about the query method of the client? I thought that queries the server, we need to hit the http endpoint of a specific Nomad client node.

@diptanu diptanu force-pushed the f-alloc-resource-usage branch from 0ef0676 to c760d59 Compare May 29, 2016 03:04
@dadgar
Copy link
Contributor

dadgar commented May 29, 2016

LGTM

@diptanu
Copy link
Contributor Author

diptanu commented May 31, 2016

Merging this to master since the tests in github.com/hashicorp/nomad/client are passing now, and the only test failures are due to connectivity issues to dockerhub.

@diptanu diptanu merged commit 9496242 into master May 31, 2016
@diptanu diptanu deleted the f-alloc-resource-usage branch May 31, 2016 01:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants