-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client APIs for reporting resource usage of host and allocations #1189
Conversation
35b6f9a
to
aa11fe8
Compare
if node.HTTPAddr == "" { | ||
return nil, fmt.Errorf("http addr of the node where alloc %q is running is not advertised", alloc.ID) | ||
} | ||
u := &url.URL{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't you use the helpers that the rest of the package uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dadgar Are you talking about the query
method of the client? I thought that queries the server, we need to hit the http endpoint of a specific Nomad client node.
…lect host stats right away
0ef0676
to
c760d59
Compare
LGTM |
Merging this to master since the tests in |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.