Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: validate reserved_ports are valid #11830

Merged
merged 2 commits into from
Jan 13, 2022
Merged

agent: validate reserved_ports are valid #11830

merged 2 commits into from
Jan 13, 2022

Conversation

schmichael
Copy link
Member

Minimal alternative to #11819. I think the more drastic changes in the other PR should wait until 1.3.

Goal is to fix at least one of the causes that can cause a node to be
ineligible to receive work:
#9506 (comment)

@schmichael schmichael added this to the 1.2.4 milestone Jan 12, 2022
@schmichael schmichael requested a review from lgfa29 January 12, 2022 20:27
schmichael added a commit that referenced this pull request Jan 12, 2022
@schmichael
doc: add changelog for #11830
eddbfcd
@vercel vercel bot temporarily deployed to Preview – nomad January 12, 2022 20:28 Inactive
@schmichael schmichael force-pushed the b-validate-reserved-ports branch from eddbfcd to a92d600 Compare January 12, 2022 20:32
@vercel vercel bot temporarily deployed to Preview – nomad January 12, 2022 20:32 Inactive
lgfa29
lgfa29 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Minor comments on output values, but not blockers 👍

command/agent/command.go Outdated Show resolved Hide resolved
nomad/structs/funcs.go Outdated Show resolved Hide resolved
@schmichael
agent: validate reserved_ports are valid
b4d3a61 
Goal is to fix at least one of the causes that can cause a node to be
ineligible to receive work:
#9506 (comment)
@schmichael
doc: add changelog for #11830
12d21aa
@schmichael schmichael force-pushed the b-validate-reserved-ports branch from a92d600 to 12d21aa Compare January 12, 2022 22:21
@vercel vercel bot temporarily deployed to Preview – nomad January 12, 2022 22:21 Inactive
@schmichael schmichael merged commit 07fd6d9 into main Jan 13, 2022
@schmichael schmichael deleted the b-validate-reserved-ports branch January 13, 2022 01:12
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
@schmichael @lgfa29
Merge pull request #11830 from hashicorp/b-validate-reserved-ports
6cf2c52 
agent: validate reserved_ports are valid
lgfa29 pushed a commit that referenced this pull request Jan 18, 2022
@schmichael @lgfa29
Merge pull request #11830 from hashicorp/b-validate-reserved-ports
cc1e484 
agent: validate reserved_ports are valid
@schmichael schmichael mentioned this pull request Jul 12, 2022
Merged
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@schmichael @lgfa29