Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use codegen for json marshalling #1182

Merged
merged 1 commit into from
May 20, 2016
Merged

Use codegen for json marshalling #1182

merged 1 commit into from
May 20, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented May 18, 2016

On the included benchmark, the switch was:

  • 20% faster
  • 12% less bytes allocated
  • 85% less allocations

@diptanu
Copy link
Contributor

diptanu commented May 20, 2016

LGTM

@dadgar dadgar merged commit 4133157 into master May 20, 2016
@dadgar dadgar deleted the f-json-encoder branch May 20, 2016 21:30
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadgar @diptanu