Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: client mount paths don't account for per-alloc field #11787

Closed
tgross opened this issue Jan 6, 2022 · 2 comments
Closed

CSI: client mount paths don't account for per-alloc field #11787

tgross opened this issue Jan 6, 2022 · 2 comments

Comments

@tgross
Copy link
Member

tgross commented Jan 6, 2022

While working on #10927 and #10833 and I noticed that the csi_hook.go sets the volume source correctly using the per-alloc flag at csi_hook.go#L168-L171 but then doesn't pass this along to the MountVolume so that it can be incorporated into the target mount path. This means that if multiple allocations from the task group land on the same host we can get a mount path collision.

@tgross
Copy link
Member Author

tgross commented Jan 6, 2022

Oops, got ahead of myself here... the mount path includes the allocation ID so it's safely namespaced there. 😊

@tgross tgross closed this as completed Jan 6, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant