CLI: Return non-zero exit code when deployment fails in nomad run

[lukas-w]

This PR changes the nomad run command (and other commands using the monitor.monitor function) to return a non-zero exit code when monitoring is enabled and deployment fails just like levant deploy does. This enables CI scripts to easily detect deployment failures. I chose return code 1 to match the existing documentation stating 0 on success, 2 on scheduling problems, and 1 for any other failures. A dedicated return code for deployment failures may makes sense though.

I also noticed and fixed a supposed typo from #10661 via 24fbb5e: The monitoring code was using DeploymentStatusDescriptionBlocked instead of DeploymentStatusBlocked.

Fixes #11082, fixes #10994.

[tgross]

Hi @lukas-w! This is looking good! Once you've addressed the comments here, if you'd like to add a changelog item for the improvement that'd be great. If that's a confusing mess (understandable), let me know and I'll get that added.

[lukas-w]

Thanks for the review @tgross! I added a changelog entry via e78fd43 but included the release-note:improvement formatting. Is that just missing in the part of the page you linked? I couldn't find any other changelog entry without a type and if I omit it, the entry isn't included in make changelog's output.

[tgross]

LGTM. The changelog entry is perfect. Thanks @lukas-w! This will ship in the next planned patch release.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.