-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Allocation Filters in Client View #11545
Conversation
Ember Asset Size actionAs of a8c9676 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
Ember Test Audit detected these flaky tests on 02aae77:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on 53e43ac:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a few comments and it's just missing tests and a CHANGELOG entry.
Co-authored-by: Luiz Aoqui <[email protected]>
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
Ember Test Audit detected these flaky tests on 770bb05:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on a8c9676:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
Ember Test Audit detected these flaky tests on efd05ea:
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Actual
Mock
@mikenomitch @juliezzhou adding the
client
filter doesn't make sense here, because all allocations in this view belong to the same client since its theclients/client
route its already filtered to show 1 client.