Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update go-getter to 1.5.9 #11481

Merged
merged 1 commit into from
Nov 17, 2021
Merged

deps: update go-getter to 1.5.9 #11481

merged 1 commit into from
Nov 17, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Nov 9, 2021

Fixes #2443

go-getter 1.5.9 includes a patch in 1.5.6 (ref hashicorp/go-getter#138) that automatically unpacks uncompressed tar archives. Previously Nomad only unpacked compressed archives, but documented that it unpacked all archives.

@tgross
Copy link
Member Author

tgross commented Nov 9, 2021

This missed 1.2.0-rc1, so leaving this in draft state until after the 1.2.0 GA goes out.

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally. :shipit:

go-getter 1.5.9 includes a patch in 1.5.6 that automatically unpacks
uncompressed tar archives. Previously Nomad only unpacked compressed
archives, but documented that it unpacked all archives.
@vercel vercel bot temporarily deployed to Preview – nomad November 17, 2021 15:49 Inactive
@tgross tgross merged commit df41bde into main Nov 17, 2021
@tgross tgross deleted the b-tar-archives branch November 17, 2021 16:14
tgross added a commit that referenced this pull request Dec 23, 2021
The `go-getter` library was updated to 1.5.9 in #11481 to pick up a
bug fix for automatically unpacking uncompressed tar archives. But
this version had a regression in git `ref` param behavior and was
patched in 1.5.10.
tgross added a commit that referenced this pull request Dec 23, 2021
The `go-getter` library was updated to 1.5.9 in #11481 to pick up a
bug fix for automatically unpacking uncompressed tar archives. But
this version had a regression in git `ref` param behavior and was
patched in 1.5.10.
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

artifacts: does not automatically unpack .tar archives
3 participants