Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad operator raft _logs doesn't stream logs #11451

Closed
tgross opened this issue Nov 4, 2021 · 2 comments · Fixed by #11684
Closed

nomad operator raft _logs doesn't stream logs #11451

tgross opened this issue Nov 4, 2021 · 2 comments · Fixed by #11684

Comments

@tgross
Copy link
Member

tgross commented Nov 4, 2021

The "hidden" command nomad operator raft _logs reads the raft logs into memory before encoding the whole blob as JSON. This makes it unusable for operators of very large clusters with 10's of GB of raft logs in flight. Modify the command to stream the logs into the JSON encoder.

(I'm torn on bug vs enhancement on this one... call it a bughancement 😀 )

@tgross
Copy link
Member Author

tgross commented Dec 15, 2021

@davemay99 has noted this also applied to operator snapshot state. But that's going to be a much bigger lift because streaming the output is somewhat at odds with how the snapshot commands work -- they restore the entire FSM. I'll break that out to another issue. Edit: #11685

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant