Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: update default node-id and docs #11398

Merged
merged 4 commits into from
Oct 27, 2021
Merged

debug: update default node-id and docs #11398

merged 4 commits into from
Oct 27, 2021

Conversation

davemay99
Copy link
Contributor

@davemay99 davemay99 commented Oct 27, 2021

This PR updates the nomad operator debug flag node-id to the most commonly used setting all. It also updates a few discrepancies between the CLI help text and website documentation.

Note: The default for max-nodes is unchanged at 10 to ensure the capture only includes a small sample of clients.

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements.

command/operator_debug.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad October 27, 2021 17:42 Inactive
@davemay99 davemay99 added this to the 1.2.0 milestone Oct 27, 2021
@davemay99 davemay99 merged commit f46b97b into main Oct 27, 2021
@davemay99 davemay99 deleted the f-debug-defaults branch October 27, 2021 17:43
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants