Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update favicon #11371

Merged
merged 2 commits into from
Oct 22, 2021
Merged

ui: update favicon #11371

merged 2 commits into from
Oct 22, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Oct 21, 2021

Update the Nomad UI favicon to match the new branding. The icon being used is the same as our website.

@lgfa29 lgfa29 requested a review from ChaiWithJai October 21, 2021 23:11
@lgfa29 lgfa29 added this to the 1.2.0 milestone Oct 21, 2021
@github-actions
Copy link

github-actions bot commented Oct 21, 2021

Ember Asset Size action

As of 86f779b

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 21, 2021

Ember Test Audit comparison

main 977c521 change
passes 1194 1194 0
failures 0 0 0
flaky 0 0 0
duration 9m 41s 871ms 9m 14s 668ms -27s 203ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit ae3d059 into main Oct 22, 2021
@lgfa29 lgfa29 deleted the f-ui-update-favicon branch October 22, 2021 13:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants