Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP headers for passing CSI secrets #11308

Closed
lgfa29 opened this issue Oct 13, 2021 · 2 comments · Fixed by #12144
Closed

Use HTTP headers for passing CSI secrets #11308

lgfa29 opened this issue Oct 13, 2021 · 2 comments · Fixed by #12144
Assignees

Comments

@lgfa29
Copy link
Contributor

lgfa29 commented Oct 13, 2021

Nomad version

Nomad v1.1.6

Operating system and Environment details

N/A

Issue

The Nomad HTTP API takes CSI secrets for the snapshot list and delete endpoints as query params. This can cause them to be written to logs.

Reproduction steps

$ nomad volume snapshot list -secrets 'k=v'

Nomad Client logs (if appropriate)

2021-10-13T17:02:34.603-0400 [ERROR] http: request failed: method=GET path="/v1/volumes/snapshot?per_page=30&secrets=k%3Dv" error="no such plugin" code=500
2021-10-13T17:02:34.603-0400 [DEBUG] http: request complete: method=GET path="/v1/volumes/snapshot?per_page=30&secrets=k%3Dv" duration=1.056939ms
@tgross tgross self-assigned this Feb 25, 2022
@tgross
Copy link
Member

tgross commented Feb 25, 2022

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants