-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Golang to 1.17.1 #11251
Upgrade Golang to 1.17.1 #11251
Conversation
mostly to handle build directives in 1.17.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like all of the changes shouldn't make CI or builds unhappy for Nomad v1.0.x (Go 1.15) if they get pulled in by a backport. Was a little worried about that, but I should have trusted the Go team to do a good job of taking backward compatibility into consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops could use a mention of 1.2.0 -> 1.17 here: https://github.com/hashicorp/nomad/blob/main/contributing/golang.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, don't forget a changelog like:
- build: Updated to Go 1.15.13 [GH-10734]
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Also, ran gofmt on all files, mostly to handle the new build directives noted in Go 1.17 release notes
https://golang.org/doc/go1.17 .
gofmt
changed few other constructs, namely initializations. I ranfind . -type f -name '*.go' -exec gofmt -s -w {} \;
.Closes #11153