jobspec2: ensure consistent error handling between var-file & var. #11165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schmichael
approved these changes
Sep 11, 2021
|
While this fixes a "bug" it will also break for all the users relying on the current behavior. Would it be possible to only merge this if an escape hatch (command line flag to allow lenient parsing) is also supplied in the same release? |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Nomad documentation, all variables used within a job specification must be defined via a variable block within the job specification file. Attempting to perform an override on a variable that doesn't exist will result in a parse error. This change fixes the behaviour, so there is consistency no matter where the override came.
closes #11149