Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: set namespace when looking for and displaying children jobs #11110

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 31, 2021

When setting the watcher for child jobs, the watcher was not setting the namespace value. This would cause periodic or parameterized jobs in a non-default namespace to query for the wrong child jobs.

Additionally, the Job Launches table was missing the possibility that the job namespace would be displayed in the table row, causing a mismatch between the number of th and td tags in the table.

Closes #10906

@lgfa29 lgfa29 requested a review from ChaiWithJai August 31, 2021 20:45
@github-actions
Copy link

github-actions bot commented Aug 31, 2021

Ember Asset Size action

As of 87ef270

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +461 B +41 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 31, 2021

Ember Test Audit comparison

main 87ef270 change
passes 1107 1123 +16
failures 0 0 0
flaky 0 0 0
duration 8m 55s 356ms 9m 28s 893ms +33s 537ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermitent issues with the Nomad UI on dispatch job children summary in namespaces
3 participants