-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add missing pipe separator in parameterized and periodic jobs #11020
Conversation
Ember Asset Size actionAs of 4a88f6c Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
For what its worth, there's an improved pattern for this that just never made it to the job details pages: https://nomad-storybook-and-ui.vercel.app/storybook/?path=/story/components-inline-definitions--standard
Ahh good to know, thank for the tip. It seems like the one being used for clients details. We should eventually migrate to that 👍 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The detail page for a child job include a header section pointing back to its parent. This header has a missing
|
separator between the job priority and the parent link.Before
After