Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add missing pipe separator in parameterized and periodic jobs #11020

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 9, 2021

The detail page for a child job include a header section pointing back to its parent. This header has a missing | separator between the job priority and the parent link.

Before

Screen Shot 2021-08-09 at 6 22 51 PM

After

Screen Shot 2021-08-09 at 6 22 55 PM

@lgfa29 lgfa29 added the theme/ui label Aug 9, 2021
@lgfa29 lgfa29 requested a review from ChaiWithJai August 9, 2021 22:31
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Ember Asset Size action

As of 4a88f6c

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +2 B +3 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 9, 2021

Ember Test Audit comparison

main 4a88f6c change
passes 1107 1107 0
failures 0 0 0
flaky 0 0 0
duration 7m 30s 205ms 8m 21s 627ms +51s 422ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

For what its worth, there's an improved pattern for this that just never made it to the job details pages: https://nomad-storybook-and-ui.vercel.app/storybook/?path=/story/components-inline-definitions--standard

@lgfa29
Copy link
Contributor Author

lgfa29 commented Aug 10, 2021

This looks good.

For what its worth, there's an improved pattern for this that just never made it to the job details pages: https://nomad-storybook-and-ui.vercel.app/storybook/?path=/story/components-inline-definitions--standard

Ahh good to know, thank for the tip. It seems like the one being used for clients details.
image

We should eventually migrate to that 👍

@lgfa29 lgfa29 merged commit f59fa98 into main Aug 10, 2021
@lgfa29 lgfa29 deleted the b-ui-add-missing-pipe branch August 10, 2021 17:48
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants