Invalidating services when they contain check of type tcp and http bu… #1097
Conversation
| @@ -1527,6 +1527,10 @@ func (s *Service) Validate() error { | |||
| } | |||
|
|
|||
| for _, c := range s.Checks { | |||
| if s.PortLabel == "" && (c.Type == ServiceCheckTCP || c.Type == ServiceCheckHTTP) { | |||
There was a problem hiding this comment.
I wonder if it would be better to pass down the PortLabel information into the check? Or to add a method to the check which returns whether it requires a port. The inspection of the type seems hacky.
There was a problem hiding this comment.
Can we validate the PortLabel exists?
There was a problem hiding this comment.
@dadgar I was wondering the same, but I thought since service block holds check blocks, it's the service block which is invalid if the check can't be supported because the service doesn't have certain capability. Validation of a check currently checks whether they have been configured correctly, for example, if a user specifies the type of the check as script, then command is mandatory.
|
LGTM |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
…t no ports