Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cni: respect default cni_config_dir and cni_path #10870

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 8, 2021

Fixes #9028

The default agent configuration values were not set, which meant they were not
being set in the client configuration and this results in fingerprints failing
unless the values were set explicitly.

The default agent configuration values were not set, which meant they were not
being set in the client configuration and this results in fingerprints failing
unless the values were set explicitly.
@tgross tgross force-pushed the b-cni-config-defaults branch from 50d5fa9 to 3b70b36 Compare July 8, 2021 13:26
@tgross tgross marked this pull request as ready for review July 8, 2021 13:26
@vercel vercel bot temporarily deployed to Preview – nomad July 8, 2021 13:26 Inactive
@tgross tgross requested review from shoenig, angrycub and notnoop July 8, 2021 13:27
@tgross tgross added this to the 1.1.3 milestone Jul 8, 2021
@tgross tgross merged commit b397edf into main Jul 8, 2021
@tgross tgross deleted the b-cni-config-defaults branch July 8, 2021 13:56
@notnoop notnoop mentioned this pull request Jul 28, 2021
notnoop pushed a commit that referenced this pull request Jul 29, 2021
The default agent configuration values were not set, which meant they were not
being set in the client configuration and this results in fingerprints failing
unless the values were set explicitly.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default cni_config_dir doesn't appear to be honored.
3 participants