CSI Listsnapshot secrets support

[ggriffiths]

Fixes #10640
Signed-off-by: Grant Griffiths [email protected]

[ggriffiths]

Still working on this one, getting a WIP PR out first.

[ggriffiths]

Tested with Portworx CSI Driver:

[root@ip-70-0-177-133 nomadspecs]# nomad volume snapshot create pxvol1 snap4
Snapshot ID         Volume ID     Size    Create Time           Ready?
833182824418993564  670065376975  10 GiB  1970-01-01T00:00:01Z  true
[root@ip-70-0-177-133 nomadspecs]# nomad volume snapshot list --secrets=auth-token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJlbWFpbCI6ImdyYW50QG9wZW5zdG9yYWdlLmlvIiwiZXhwIjoxNjI2OTMzODc0LCJncm91cHMiOlsiKiJdLCJpYXQiOjE2MjY4NDc0NzQsImlzcyI6Im9wZW5zdG9yYWdlLmlvIiwibmFtZSI6IkdyYW50Iiwicm9sZXMiOlsic3lzdGVtLmFkbWluIl0sInN1YiI6ImdyYW50QG9wZW5zdG9yYWdlLmlvIn0.Tvz8ZjXLvXb8Z5JCg4UEfbfYb2MFo3CLBRBXxqZ22yE
Snapshot ID          Volume ID     Size    Create Time  Ready?
833182824418993564   670065376975  10 GiB  <none>       true
523181979236462009   670065376975  10 GiB  <none>       true
1102101751991941593  670065376975  10 GiB  <none>       true
788455741817460122   670065376975  10 GiB  <none>       true
[root@ip-70-0-177-133 nomadspecs]# nomad volume snapshot list --secrets=auth-token=bad
Error querying CSI external snapshots for plugin "": Unexpected response code: 500 (controller list snapshots: CSI.ControllerListSnapshots: controller plugin returned an internal error, check the plugin allocation logs for more information: rpc error: code = Internal desc = Unable to get all snapshots: rpc error: code = Unauthenticated desc = Unable to obtain token issuer from authorization token: Token is invalid: bad)
[root@ip-70-0-177-133 nomadspecs]# nomad volume snapshot list --secrets=a=b,auth-token=second-arg-passed
Error querying CSI external snapshots for plugin "": Unexpected response code: 500 (rpc error: controller list snapshots: rpc error: controller list snapshots: rpc error: controller list snapshots: CSI.ControllerListSnapshots: controller plugin returned an internal error, check the plugin allocation logs for more information: rpc error: code = Internal desc = Unable to get all snapshots: rpc error: code = Unauthenticated desc = Unable to obtain token issuer from authorization token: Token is invalid: second-arg-passed)

[ggriffiths]

Added a small unit test addition. Ready for review.

[schmichael]

Looks great @ggriffiths! Thanks for contributing!

There's a few other steps. I can take care of them if you don't want to! Just let me know.

• Changelog entry (create a file .changelog/10848.txt and see https://github.com/hashicorp/nomad/blob/main/contributing/CHANGELOG.md#developer-guide)
• CLI docs - website / code
• API docs - website / code

https://github.com/hashicorp/nomad/blob/main/contributing/checklist-command.md is hopefully helpful, but we don't do a good job of pointing people to it. Sorry!

[ggriffiths]

Cool, I'll work on those steps. Thanks for taking a look!

[ggriffiths]

Added the docs and changelog @schmichael

[ggriffiths]

@schmichael, let me know if anything else is needed here. Hoping to get this in for the next minor release.

[schmichael]

Fantastic. Thanks for sticking with this @ggriffiths! It will ship in our next release!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.