Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devices: externalize nvidia device driver #10796

Merged
merged 1 commit into from
Sep 29, 2021
Merged

devices: externalize nvidia device driver #10796

merged 1 commit into from
Sep 29, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 21, 2021

Fixes #8330 (and gets us closer to #5643)

This PR externalizes the Nvidia device driver (it's been copied to its own repository at https://github.com/hashicorp/nomad-device-nvidia).

@tgross
Copy link
Member Author

tgross commented Jun 21, 2021

Depending on how folks feel about breaking existing users of the Nvidia driver, we may want to hold off landing this until we're ready to ship Nomad 1.2.0.

@the-maldridge
Copy link

This feels like a 1.2.0 type change. Almost all other large changes like this have been in the bigger bumps, so intuitively it feels like this should be too.

I'd also say that libcontainer is much more portable than the nvidia drivers and supports static linking.

@tgross tgross added this to the 1.2.0 milestone Jun 21, 2021
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and +1 on 1.2.0 as @tgross and @the-maldridge have discussed. Luckily it's a pretty tidy PR so hopefully letting it hang out won't cause much merge pain.

website/data/docs-nav-data.json Outdated Show resolved Hide resolved
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalize Nvidia device plugin
3 participants