-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devices: externalize nvidia device driver #10796
Conversation
Depending on how folks feel about breaking existing users of the Nvidia driver, we may want to hold off landing this until we're ready to ship Nomad 1.2.0. |
This feels like a 1.2.0 type change. Almost all other large changes like this have been in the bigger bumps, so intuitively it feels like this should be too. I'd also say that libcontainer is much more portable than the nvidia drivers and supports static linking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and +1 on 1.2.0 as @tgross and @the-maldridge have discussed. Luckily it's a pretty tidy PR so hopefully letting it hang out won't cause much merge pain.
42e3dcd
to
86dd15d
Compare
86dd15d
to
420bce0
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #8330 (and gets us closer to #5643)
This PR externalizes the Nvidia device driver (it's been copied to its own repository at https://github.com/hashicorp/nomad-device-nvidia).