-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed global-search keyboard shortcut for non-english keyboard layouts. #10714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apollo13 apparently this broke the tests for this feature (see https://app.circleci.com/pipelines/github/hashicorp/nomad/16480/workflows/7875e4f3-ede6-4c81-9eeb-5834becb6ea5/jobs/159133), so maybe there's some magic here around key codes that I'm not aware of.
Thanks @tgross, I think the error makes sense since it sends |
I have no clue why the github workflow fails. But aside from that the patch looks good :) |
That GitHub Action needs to write a comment in the PR... which needs a GH token with write permissions and we don't expose that to forks. Safe to ignore. LGTM! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #10646