Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed global-search keyboard shortcut for non-english keyboard layouts. #10714

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

apollo13
Copy link
Contributor

@apollo13 apollo13 commented Jun 7, 2021

Closes #10646

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/app/components/global-search/control.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apollo13 apparently this broke the tests for this feature (see https://app.circleci.com/pipelines/github/hashicorp/nomad/16480/workflows/7875e4f3-ede6-4c81-9eeb-5834becb6ea5/jobs/159133), so maybe there's some magic here around key codes that I'm not aware of.

@apollo13
Copy link
Contributor Author

apollo13 commented Jun 7, 2021

Thanks @tgross, I think the error makes sense since it sends keyCode as event data and not key. I added a commit to fix that. The error makes sense since manually triggering a event with only keyCode is not what the browser would do…

@apollo13
Copy link
Contributor Author

apollo13 commented Jun 7, 2021

I have no clue why the github workflow fails. But aside from that the patch looks good :)

@apollo13 apollo13 requested a review from tgross June 7, 2021 16:56
@tgross
Copy link
Member

tgross commented Jun 7, 2021

I have no clue why the github workflow fails.

That GitHub Action needs to write a comment in the PR... which needs a GH token with write permissions and we don't expose that to forks. Safe to ignore.

LGTM!

@tgross tgross added this to the 1.1.1 milestone Jun 7, 2021
@tgross tgross merged commit 5f968ba into hashicorp:main Jun 7, 2021
tgross added a commit that referenced this pull request Jun 7, 2021
tgross added a commit that referenced this pull request Jun 7, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using "/" to focus search box does not work in Firefox
2 participants