Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: validate volume block has attachment_mode and access_mode #10651

Merged
merged 1 commit into from
Jun 3, 2021
Merged

csi: validate volume block has attachment_mode and access_mode #10651

merged 1 commit into from
Jun 3, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented May 24, 2021

Fixes #10645

The attachment_mode and access_mode fields are required for CSI
volumes. The mount_options block is only allowed for CSI volumes.

@tgross tgross added this to the 1.1.1 milestone May 24, 2021
@tgross tgross force-pushed the b-csi-volume-validation branch from 0f90bb4 to 1df6ebf Compare May 24, 2021 15:37
@vercel vercel bot temporarily deployed to Preview – nomad May 24, 2021 15:37 Inactive
@tgross tgross force-pushed the b-csi-volume-validation branch from 1df6ebf to 27afec8 Compare May 24, 2021 15:40
@vercel vercel bot temporarily deployed to Preview – nomad May 24, 2021 15:40 Inactive
@tgross tgross force-pushed the b-csi-volume-validation branch from 27afec8 to bbfca71 Compare May 24, 2021 16:01
@vercel vercel bot temporarily deployed to Preview – nomad May 24, 2021 16:02 Inactive
@tgross tgross marked this pull request as ready for review May 24, 2021 16:11
@tgross tgross requested review from shoenig and notnoop May 24, 2021 16:11
@tgross
csi: validate volume block has attachment_mode and access_mode
44bd789 
The `attachment_mode` and `access_mode` fields are required for CSI
volumes. The `mount_options` block is only allowed for CSI volumes.
@tgross tgross force-pushed the b-csi-volume-validation branch from bbfca71 to 44bd789 Compare June 3, 2021 14:24
@vercel vercel bot temporarily deployed to Preview – nomad June 3, 2021 14:24 Inactive
@tgross
Copy link
Member Author

tgross commented Jun 3, 2021

I've updated this PR with some more test coverage and rebased it on main.

@tgross tgross requested a review from drewbailey June 3, 2021 15:22
@tgross tgross mentioned this pull request Jun 3, 2021
Closed
@vercel vercel bot temporarily deployed to Preview – nomad June 3, 2021 19:46 Inactive
@tgross tgross force-pushed the b-csi-volume-validation branch from 0b10d98 to 44bd789 Compare June 3, 2021 19:47
drewbailey
drewbailey approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tgross tgross merged commit cfaf6a3 into main Jun 3, 2021
@tgross tgross deleted the b-csi-volume-validation branch June 3, 2021 20:07
@tgross tgross mentioned this pull request Jun 3, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drewbailey drewbailey drewbailey approved these changes

@shoenig shoenig Awaiting requested review from shoenig

@notnoop notnoop Awaiting requested review from notnoop

Assignees
No one assigned
Labels
theme/storage
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

[csi] nomad plan does not fail when required fields are missing in the volume stanza
2 participants
@tgross @drewbailey