Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display confirmation message on 'nomad volume delete' and 'nomad volume deregister' #10591

Merged
merged 3 commits into from
May 24, 2021
Merged

Display confirmation message on 'nomad volume delete' and 'nomad volume deregister' #10591

merged 3 commits into from
May 24, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented May 13, 2021

Before:
image

After:
image

@lgfa29 lgfa29 requested a review from tgross May 13, 2021 21:47
@vercel vercel bot temporarily deployed to Preview – nomad May 13, 2021 22:43 Inactive
@lgfa29 lgfa29 changed the title Display confirmation message on 'nomad volume delete' Display confirmation message on 'nomad volume delete' and 'nomad volume deregister' May 13, 2021
tgross
tgross approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@tgross tgross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's queue up a changelog entry for 1.1.1 for this.

@tgross tgross added this to the 1.1.1 milestone May 14, 2021
@tgross tgross force-pushed the cmd-volume-delete-confirm branch from 67dd01e to b18fd25 Compare May 24, 2021 15:42
@vercel vercel bot temporarily deployed to Preview – nomad May 24, 2021 15:42 Inactive
@tgross tgross force-pushed the cmd-volume-delete-confirm branch from b18fd25 to 7c46403 Compare May 24, 2021 15:43
@vercel vercel bot temporarily deployed to Preview – nomad May 24, 2021 15:43 Inactive
@tgross
Copy link
Member

tgross commented May 24, 2021

I've rebased this on main and added the changelog entry. Once it's green on CI again I'll merge it and it'll ship in the next Nomad patch

@tgross tgross merged commit 3c2f1d1 into main May 24, 2021
@tgross tgross deleted the cmd-volume-delete-confirm branch May 24, 2021 16:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lgfa29 @tgross