-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ACL Token to be provided by a Reverse Proxy #10561
Comments
Signed-off-by: Georges-Etienne Legendre <[email protected]>
Thanks for opening this issue @legege! I've assigned this to @backspace so that once we review that PR we can determine whether that really closes out the issue described here. |
Sorry @legege, we're in the middle of onboarding some folks onto the UI side of the team and that's creating a bit of delay there. I've changed the reviewer and pulled in one of our product security folks for review as well. |
We use enterprise versions of Nomad, Vault, Consul and Terraform. Currently Nomad is the only product that doesnt support SSO. Our current Nomad authentication method is based on AWS credentials and reading from the Nomad secrets engine in Vault to obtain a short lived token. We have 100s of developers that we'd like to onboard to Nomad across some 15+ Nomad namespaces. In the end, we gain very little adoption from engineering teams because it's simply too inconvenient to navigate the authenticate workflow. We want our developers in Nomad, but we have to make it easy. This also goes for our operations teams. They should be comfortable getting into Nomad to potentially do first pass troubleshooting, restarting failed jobs, etc. It's hard to fathom integrating a product into an enterprise these days without SSO. We view Nomad as an enterprise product and need SSO to successfully integrate. |
* Proposed fix for #10561 Signed-off-by: Georges-Etienne Legendre <[email protected]> * Add acceptance tests for reverse proxy use-case Signed-off-by: Georges-Etienne Legendre <[email protected]> * Use reads instead of computed/get Signed-off-by: Georges-Etienne Legendre <[email protected]> * Move back the line closer to the task Signed-off-by: Georges-Etienne Legendre <[email protected]> * skip a11y-audit-called lint rule on reverse proxy tests Co-authored-by: Luiz Aoqui <[email protected]>
Looks like #10563 potentially fixes this issue (though native integration with Okta would be great). |
You are right @josegonzalez, this particular issue was fixed in #10563, so I am going to close this as fixed 🙂 @tfeyereisen-exactsciences SSO support is part of a larger discussion, so I created #10999 for us to track it. Feel free to 👍 and add any additional comments you may have. |
@legege do you happen to have an nginx conf or some similar thing that implements the auth reverse proxy flow for reference? |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Proposal
It would be useful to allow a Reverse Proxy to set the Nomad ACL Token via the header
X-Nomad-Token
.Use-cases
Allowing a Reverse Proxy to inject this ACL Token can help to implement some login flow with 3rd party SSO. Consul does support that today.
The idea is also mentioned in this comment (issue #6054).
Attempted Solutions
References
The text was updated successfully, but these errors were encountered: