CSI: capability block is required for volume registration #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-csi-registration-must-include-cap
branch
from
d410f87 to
245356b
Compare
tgross
force-pushed
the
b-csi-registration-must-include-cap
branch
from
245356b to
8c28814
Compare
tgross
requested review from
shoenig,
notnoop and
drewbailey
and removed request for
shoenig
shoenig
reviewed
Apr 8, 2021
| AccessMode: structs.CSIVolumeAccessModeMultiNodeReader, // ignored in create | ||
| AttachmentMode: structs.CSIVolumeAttachmentModeFilesystem, // ignored in create | ||
| AccessMode: structs.CSIVolumeAccessModeSingleNodeReader, // legacy field ignored | ||
| AttachmentMode: structs.CSIVolumeAttachmentModeBlockDevice, // legacy field ignored |
There was a problem hiding this comment.
Should these be marked for removal in a future version?
There was a problem hiding this comment.
It's only deprecated for registration/creation... they're still returned on read once a claim is made.
shoenig
approved these changes
Apr 8, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for
capabilityblocks on volume registration (as well as creation, where it was previously documented). Update documentation and CHANGELOG for new feature and this backwards incompatibility in the volume spec.(ref #10322 for the E2E test updates for this.)