XHR keys need to include the method as well

The URL alone doesn't guarantee uniqueness
hashicorp · May 22, 2018 · ee4aa99 · ee4aa99
1 parent 173a2b9
commit ee4aa99
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ui/app/adapters/job.js b/ui/app/adapters/job.js
@@ -49,9 +49,9 @@ export default Watchable.extend({
   xhrKey(url, method, options = {}) {
     const namespace = options.data && options.data.namespace;
     if (namespace) {
-      return `${url}?namespace=${namespace}`;
+      return `${method} ${url}?namespace=${namespace}`;
     }
-    return url;
+    return `${method} ${url}`;
   },
 
   relationshipFallbackLinks: {

diff --git a/ui/app/adapters/watchable.js b/ui/app/adapters/watchable.js
@@ -51,8 +51,8 @@ export default ApplicationAdapter.extend({
     return ajaxOptions;
   },
 
-  xhrKey(url /* method, options */) {
-    return url;
+  xhrKey(url, method /* options */) {
+    return `${method} ${url}`;
   },
 
   findAll(store, type, sinceToken, snapshotRecordArray, additionalParams = {}) {