From e82dad732beaa6e4113b84c25d35757639f2e333 Mon Sep 17 00:00:00 2001 From: Mahmood Ali Date: Fri, 13 Dec 2019 11:08:12 -0500 Subject: [PATCH] address review comments --- client/allocrunner/taskrunner/logmon_hook.go | 2 +- drivers/docker/config.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/client/allocrunner/taskrunner/logmon_hook.go b/client/allocrunner/taskrunner/logmon_hook.go index c4c77f002c8..b983929599d 100644 --- a/client/allocrunner/taskrunner/logmon_hook.go +++ b/client/allocrunner/taskrunner/logmon_hook.go @@ -104,7 +104,7 @@ func (h *logmonHook) Prestart(ctx context.Context, req *interfaces.TaskPrestartRequest, resp *interfaces.TaskPrestartResponse) error { if h.isLoggingDisabled() { - h.logger.Info("logging is disabled by driver") + h.logger.Debug("logging is disabled by driver") return nil } diff --git a/drivers/docker/config.go b/drivers/docker/config.go index ec4ccf7b5ec..33c8b5ff0a8 100644 --- a/drivers/docker/config.go +++ b/drivers/docker/config.go @@ -258,6 +258,8 @@ var ( hclspec.NewLiteral(`"gcr.io/google_containers/pause-amd64:3.0"`), ), + // disable_log_collection indicates whether docker driver should collect logs of docker + // task containers. If true, nomad doesn't start docker_logger/logmon processes "disable_log_collection": hclspec.NewAttr("disable_log_collection", "bool", false), })