Tests

hashicorp · Feb 2, 2016 · 7ea6619 · 7ea6619
1 parent 95e6a62
commit 7ea6619
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/command/util_test.go b/command/util_test.go
@@ -40,7 +40,11 @@ func testServer(
 
 func testJob(jobID string) *api.Job {
 	task := api.NewTask("task1", "exec").
-		Require(&api.Resources{MemoryMB: 256})
+		Require(&api.Resources{
+		MemoryMB: 256,
+		DiskMB:   20,
+		CPU:      100,
+	})
 
 	group := api.NewTaskGroup("group1", 1).
 		AddTask(task)

diff --git a/nomad/mock/mock.go b/nomad/mock/mock.go
@@ -106,6 +106,7 @@ func Job() *structs.Job {
 						Resources: &structs.Resources{
 							CPU:      500,
 							MemoryMB: 256,
+							DiskMB:   100,
 							Networks: []*structs.NetworkResource{
 								&structs.NetworkResource{
 									MBits:        50,

diff --git a/nomad/structs/structs.go b/nomad/structs/structs.go
@@ -1616,8 +1616,7 @@ func (t *Task) Validate() error {
 	// Validate the resources.
 	if t.Resources == nil {
 		mErr.Errors = append(mErr.Errors, errors.New("Missing task resources"))
-	}
-	if err := t.Resources.MeetsMinResources(); err != nil {
+	} else if err := t.Resources.MeetsMinResources(); err != nil {
 		mErr.Errors = append(mErr.Errors, err)
 	}
 

diff --git a/nomad/structs/structs_test.go b/nomad/structs/structs_test.go
@@ -252,9 +252,14 @@ func TestTask_Validate(t *testing.T) {
 	}
 
 	task = &Task{
-		Name:      "web",
-		Driver:    "docker",
-		Resources: &Resources{},
+		Name:   "web",
+		Driver: "docker",
+		Resources: &Resources{
+			CPU:      100,
+			DiskMB:   100,
+			MemoryMB: 100,
+			IOPS:     10,
+		},
 	}
 	err = task.Validate()
 	if err != nil {