From 0d433b1c8910e217b647aa98fa07ecca9d44b5a5 Mon Sep 17 00:00:00 2001
From: Michael Lange <dingoeatingfuzz@gmail.com>
Date: Thu, 9 Jul 2020 17:01:34 -0700
Subject: [PATCH] Filter out new records from the job list page

When a prefix is set and the run job button is clicked,
the new job causes an error because it has no name yet.
---
 ui/app/controllers/jobs/index.js      |  1 +
 ui/tests/acceptance/jobs-list-test.js | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/ui/app/controllers/jobs/index.js b/ui/app/controllers/jobs/index.js
index c6312472fb4..c1cacfbcc18 100644
--- a/ui/app/controllers/jobs/index.js
+++ b/ui/app/controllers/jobs/index.js
@@ -163,6 +163,7 @@ export default class IndexController extends Controller.extend(Sortable, Searcha
 
     return this.model
       .compact()
+      .filter(job => !job.isNew)
       .filter(job => !hasNamespaces || job.get('namespace.id') === activeNamespace)
       .filter(job => !job.get('parent.content'));
   }
diff --git a/ui/tests/acceptance/jobs-list-test.js b/ui/tests/acceptance/jobs-list-test.js
index bf0d7b1a55a..ff5b438381c 100644
--- a/ui/tests/acceptance/jobs-list-test.js
+++ b/ui/tests/acceptance/jobs-list-test.js
@@ -452,5 +452,19 @@ module('Acceptance | jobs list', function(hooks) {
         'URL has the correct query param key and value'
       );
     });
+
+    test('the run job button works when filters are set', async function(assert) {
+      ['pre-one', 'pre-two', 'pre-three'].forEach(name => {
+        server.create('job', { name, createAllocations: false, childrenCount: 0 });
+      });
+
+      await JobsList.visit();
+
+      await JobsList.facets.prefix.toggle();
+      await JobsList.facets.prefix.options[0].toggle();
+
+      await JobsList.runJobButton.click();
+      assert.equal(currentURL(), '/jobs/run');
+    });
   }
 });