Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Ability to configure dns server list #54

Merged
merged 1 commit into from
Jul 31, 2020
Merged

config: Ability to configure dns server list #54

merged 1 commit into from
Jul 31, 2020

Conversation

towe75
Copy link
Collaborator

@towe75 towe75 commented Jul 31, 2020

Driver config can now specify a list of dns servers:

  • dns - (Optional) A list of dns servers. Replaces the default from podman binary and containers.conf.
config {
  dns = [
    "1.1.1.1"
  ]
}

@towe75 towe75 requested a review from drewbailey July 31, 2020 06:44
@drewbailey
Copy link
Contributor

Looks good to me!

@towe75 towe75 merged commit 49d9894 into master Jul 31, 2020
@drewbailey
Copy link
Contributor

Hey @towe75 I missed that this Nomad PR had landed hashicorp/nomad#7661 I think we should instead allow the value set in network > dns to be plummed through to podman

@drewbailey
Copy link
Contributor

Created #56 to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbailey drewbailey drewbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@towe75 @drewbailey