You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Certificate retry inhibiting would be broken in Go 1.20.
The upstream CL http://go.dev/cl/449336 changed the error type returned when there's a certificate verification failure. The following line no longer hits:
I believe it would resume working (and also work for older Go versions) if this was changed to:
// Don't retry if the error was due to TLS cert verification failure.
- if _, ok := v.Err.(x509.UnknownAuthorityError); ok {+ if _, ok := errors.As(v.Err, &x509.UnknownAuthorityError{}); ok {
return false, nil
}
The text was updated successfully, but these errors were encountered:
Certificate retry inhibiting would be broken in Go 1.20.
The upstream CL http://go.dev/cl/449336 changed the error type returned when there's a certificate verification failure. The following line no longer hits:
go-retryablehttp/client.go
Lines 476 to 478 in 493aa4c
I believe it would resume working (and also work for older Go versions) if this was changed to:
The text was updated successfully, but these errors were encountered: