You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I check the second parameter of AddSampleWithLabels, it all convert from float32 to float64, why not use float64 directly?
As the example below, the result of time.Since(s).Milliseconds() is float64, i have to convert to float32, and in AddSampleWithLabels it will convert to float64 again...
go-metrics/prometheus/prometheus.go
Line 329 in 0ec7440
I check the second parameter of
AddSampleWithLabels
, it all convert from float32 to float64, why not use float64 directly?As the example below, the result of
time.Since(s).Milliseconds()
isfloat64
, i have to convert to float32, and inAddSampleWithLabels
it will convert to float64 again...The text was updated successfully, but these errors were encountered: