Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codify working and non-working s3 url examples in the README #387

Open
ghost opened this issue Oct 18, 2022 · 0 comments
Open

Codify working and non-working s3 url examples in the README #387

ghost opened this issue Oct 18, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 18, 2022

The s3 section in the README links to https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html
In that page it has examples of virtual-hosted style access, the deprecated path-styl-access, neither of which work with go-getter (apparently because of the http:// or https:// scheme at the beginning of the urls). This also means that the object url link in the s3 page does not work for the same reason. Surprisingly the s3:// mentioned in https://docs.aws.amazon.com/AmazonS3/latest/userguide/access-bucket-intro.html#accessing-a-bucket-using-S3-format does work, but isn't mentioned in the examples.

Ideally the examples would show what does work, and then examples of what does not work ie something like

Supported formats:

Unsupported formats (will NOT work)

As a sidenote, it would be really nice if go-getter did work for s3 URLs when they are prefixed with http:// or https://.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants