Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for virtual host style s3 uris #199

Closed
jcrowgey opened this issue Aug 30, 2019 · 1 comment
Closed

Support for virtual host style s3 uris #199

jcrowgey opened this issue Aug 30, 2019 · 1 comment

Comments

@jcrowgey
Copy link

Amazon has published some guidelines which suggest migrating away from path-style s3 uris:

https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

go-getter seems to only support path-style, however:

conf.S3ForcePathStyle = aws.Bool(true)

Or, perhaps I'm missing something, since I do see that virtual-host style uris are delectable:

func (d *S3Detector) detectVhostStyle(region, bucket string, parts []string) (string, bool, error) {

@picatz
Copy link
Contributor

picatz commented Nov 13, 2020

Should be fixed with #283

@picatz picatz closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants