Add more streaming tests #9188
Merged
Add more streaming tests #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
added
the
theme/streaming
github-actions
bot
added
theme/health-checks
dnephin
added
backport/1.9
and removed
theme/health-checks
dnephin
force-pushed
the
dnephin/more-streaming-tests
branch
from
35b13a4 to
e0014fe
Compare
dnephin
force-pushed
the
dnephin/more-streaming-tests
branch
from
e72316f to
f65b990
Compare
dnephin
force-pushed
the
dnephin/more-streaming-tests
branch
from
f65b990 to
8963d4b
Compare
Restored from streaming-rpc-final branch. Co-authored-by: Paul Banks <[email protected]>
Add a test for catalog_event snapshot on connect topic
dnephin
force-pushed
the
dnephin/more-streaming-tests
branch
from
8963d4b to
1156519
Compare
banks
approved these changes
Feb 26, 2021
| payload.key = n.Service.Proxy.DestinationServiceName | ||
| } | ||
|
|
||
| event.Payload = payload |
There was a problem hiding this comment.
Was this a bug found by the added tests?
There was a problem hiding this comment.
Unfortunately not, I think the test I had added only tested the non-connect topic. This bug was found as a result of the work Mishra is doing. I added the second snapshot test after we found the bug.
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332868. |
|
🍒✅ Cherry pick of commit 6b95e8d onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Feb 26, 2021
Add more streaming tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a small error in the streaming docs.
Adds some additional unit and integration tests for streaming.