Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade "github.com/hashicorp/raft" to v1.1.2 #7087

Closed
onlyjob opened this issue Jan 19, 2020 · 3 comments
Closed

Please upgrade "github.com/hashicorp/raft" to v1.1.2 #7087

onlyjob opened this issue Jan 19, 2020 · 3 comments

Comments

@onlyjob
Copy link

onlyjob commented Jan 19, 2020

Currently Consul 1.5.2 FTBFS with github.com/hashicorp/raft v1.1.2 as follows:

# github.com/hashicorp/consul/agent/consul 
src/github.com/hashicorp/consul/agent/consul/server.go:584:3: cannot use s.logger (type *log.Logger) as type hclog.Logger in field value: 
        *log.Logger does not implement hclog.Logger (missing Debug method) 
@schristoff
Copy link
Contributor

Howdy @onlyjob, thank you for bringing this to our attention.
In the more recent versions of Raft we were able to update the Raft logger to use hclog. Because of this we made this update in Consul so it could work with Raft's hclogs. Please update Consul and it should be able to work with the updated Raft version.

@schristoff schristoff added the waiting-reply Waiting on response from Original Poster or another individual in the thread label Jan 21, 2020
@hanshasselberg hanshasselberg removed the waiting-reply Waiting on response from Original Poster or another individual in the thread label Jan 21, 2020
@hanshasselberg
Copy link
Member

Closing since there is nothing left for us to do.

@onlyjob
Copy link
Author

onlyjob commented Jan 21, 2020

Thank you. Cherry-picking 5f57b95 fixed the FTBFS with raft v1.1.2 - very helpful.

As for upgrading Consul, I'd very much like to do that but lack of harmony in Hashicorp ecosystem holds the progress back: hashicorp/nomad#6785. Because of this issue with Nomad I can not upgrade Consul 1.5.2 in Debian...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants