Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: change router syntax for matching query parameters to resemble the syntax for matching paths and headers for consistency. #6163

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jul 17, 2019

This is a breaking change, but only in the context of the beta series.

@rboyer rboyer added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Jul 17, 2019
@rboyer rboyer added this to the 1.6.0-beta3 milestone Jul 17, 2019
@rboyer rboyer requested a review from a team July 17, 2019 21:12
@rboyer rboyer self-assigned this Jul 17, 2019
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rboyer rboyer force-pushed the l7-config-and-validate branch from 6ad6634 to 53a1050 Compare July 24, 2019 00:55
@rboyer rboyer force-pushed the router-field-renames branch 2 times, most recently from eeefdd8 to fa99788 Compare July 24, 2019 01:40
@rboyer rboyer changed the base branch from l7-config-and-validate to release/1-6 July 24, 2019 01:53
…le the syntax for matching paths and headers for consistency.

This is a breaking change, but only in the context of the beta series.
@rboyer rboyer force-pushed the router-field-renames branch from fa99788 to e9b2457 Compare July 24, 2019 01:54
@rboyer rboyer merged commit 85cf270 into release/1-6 Jul 24, 2019
@rboyer rboyer deleted the router-field-renames branch July 24, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants