Fix the coordinate update endpoint not passing the ACL token #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
reviewed
Feb 15, 2018
| @@ -168,6 +168,7 @@ func (s *HTTPServer) CoordinateUpdate(resp http.ResponseWriter, req *http.Reques | |||
| return nil, nil | |||
| } | |||
| s.parseDC(req, &args.Datacenter) | |||
| s.parseToken(req, &args.Token) | |||
There was a problem hiding this comment.
this looks good but don't you also need it right before the other RPCS in this method?
There was a problem hiding this comment.
what other RPC calls are there?
preetapan
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coordinate update HTTP endpoint was leaving the token empty on its RPC call - the agents internally hit the RPC endpoint directly for coordinate updates so this was only affecting external tools that called it.