Add client ip to http access logs

[gozer]

Fixes #1447

[slackpad]

Hi @gozer - would you mind sticking the address at the end of the log message and using the new log functions from memberlist, so these will all look the same? Here's an example: https://github.com/hashicorp/consul/blob/master/consul/rpc.go#L86. There's a LogAddr function that should work for your use case here. Thanks!

[gozer]

Absolutely, will do and update my PR

[gozer]

memberlist.LogAddress wants a net.Addr, and req.RemoteAddr is already just a string, not an address anymore, so not sure it's worth trying to convert it back to a net.Addr

[slackpad]

@gozer sorry I didn't realize that. In that case, it should be good enough to stick it at the end as "... from=%s" to match the memberlist format. Agree it's not worth converting to an address.

[gozer]

@slackpad done as suggested

[slackpad]

@gozer thanks for the update! One other thing - I think your split() call will mangle IPV6 addresses - since it's just a string I'd probably just print it with the port number.

[gozer]

@slackpad, you are absolutely correct, that address splitting had bothered me from the start, to be honest. Removed as suggested.

[slackpad]

LGTM - Thanks!