Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: prevent top-level verify_incoming enabling mTLS on gRPC port #13118

Merged
merged 1 commit into from
May 18, 2022

Conversation

boxofrad
Copy link
Contributor

Description

Fixes #13088, a backwards-compatibility bug introduced in 1.12.

@boxofrad boxofrad added type/bug Feature does not function as expected backport/1.12 labels May 18, 2022
@hashicorp-ci
Copy link
Contributor

After merging, confirm that you see linked PRs AND check that them for CI errors.

@github-actions github-actions bot added the theme/config Relating to Consul Agent configuration, including reloading label May 18, 2022
Fixes #13088

This is a backwards-compatibility bug introduced in 1.12.
@boxofrad boxofrad force-pushed the boxofrad/tls-verify-incoming-grpc-bug branch from fe2c19a to 836722c Compare May 18, 2022 14:24
@boxofrad boxofrad requested review from a team and mkeeler and removed request for a team May 18, 2022 14:25
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/config Relating to Consul Agent configuration, including reloading type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify_outgoing not supported on gRPC listener; verify_incoming breaks Consul Connect envoy sidecars
3 participants