Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Meta to ServiceConfigResponse #12529

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Add Meta to ServiceConfigResponse #12529

merged 2 commits into from
Mar 7, 2022

Conversation

erichaberkorn
Copy link
Contributor

This ensures that terminating gateway proxycfg snapshots have Meta populated on ServiceConfigs. The Meta key on ServiceConfigResponse will end up being used to configure the serverless plugin.

@erichaberkorn erichaberkorn force-pushed the add-meta-to-service-config-response branch from c8f79fc to f7cc7ff Compare March 7, 2022 15:05
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 7, 2022 15:05 Inactive
@vercel vercel bot temporarily deployed to Preview – consul March 7, 2022 15:05 Inactive
@erichaberkorn erichaberkorn marked this pull request as ready for review March 7, 2022 15:25
@erichaberkorn erichaberkorn requested a review from rboyer March 7, 2022 15:25
rboyer
rboyer reviewed Mar 7, 2022
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – consul March 7, 2022 19:35 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 7, 2022 19:35 Inactive
@erichaberkorn erichaberkorn force-pushed the add-meta-to-service-config-response branch from 5913920 to 9d0ec2e Compare March 7, 2022 19:40
@vercel vercel bot temporarily deployed to Preview – consul March 7, 2022 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 7, 2022 19:40 Inactive
rboyer
rboyer approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erichaberkorn erichaberkorn merged commit abfcde1 into main Mar 7, 2022
@erichaberkorn erichaberkorn deleted the add-meta-to-service-config-response branch March 7, 2022 21:35
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/603974.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

Assignees

@erichaberkorn erichaberkorn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erichaberkorn @hc-github-team-consul-core @rboyer