server: ensure that service-defaults meta is incorporated into the discovery chain response #12511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
commented
Mar 3, 2022
rboyer
force-pushed
the
expose-service-meta-on-disco-chain
branch
from
e94d91b to
0441e7c
Compare
rboyer
force-pushed
the
expose-service-meta-on-disco-chain
branch
from
0f61568 to
65c1032
Compare
erichaberkorn
approved these changes
Mar 4, 2022
|
|
…scovery chain response Also add a new "Default" field to the discovery chain response to clients
rboyer
force-pushed
the
expose-service-meta-on-disco-chain
branch
from
508ad93 to
64830bd
Compare
mkeeler
reviewed
Mar 24, 2022
| @@ -109,9 +109,17 @@ type CompiledDiscoveryChain struct { | |||
| // non-customized versions. | |||
| CustomizationHash string | |||
|
|
|||
| // Default indicates if this discovery chain is based on no | |||
There was a problem hiding this comment.
Should the API docs be updated to account for these changes.
There was a problem hiding this comment.
IIRC we don't currently document the full disco chain response at all.
mkeeler
approved these changes
Mar 25, 2022
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/617584. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a new "Default" field to the discovery chain response to clients (cc @johncowen )
TODO: