Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: [Bugfix] Added Tags tab to gateways(just like exists for non-gateway services) #12400

Merged

Conversation

chinmaym07
Copy link
Contributor

fixes: #11322

Signed-off-by: chinmaym07 [email protected]

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 20, 2022

CLA assistant check
All committers have signed the CLA.

@johncowen johncowen added theme/ui Anything related to the UI type/bug Feature does not function as expected labels Feb 21, 2022
@johncowen
Copy link
Contributor

Thanks for looking at this @chinmaym07 , looks perfect! Lemme just give it a run first. I've done a couple of housekeeping tasks here (added some categorising labels and tweaked your title a little) just to help us find things if we ever have to in the future. I think the only thing I might need you to add is a changelog. I think this one might be good to backport to other version also. Lemme look a little more and I'll let you know 👍

@johncowen johncowen changed the title fix: Added Tags tab to gateways(just like exists for non-gateway services) ui: [Bugfix] Added Tags tab to gateways(just like exists for non-gateway services) Feb 21, 2022
@johncowen johncowen self-requested a review February 21, 2022 12:32
@johncowen
Copy link
Contributor

Hey @chinmaym07

Just to let you know I took this for a spin and it's all good. Let me know if you want to add a changelog yourself, otherwise I can do it from here if that's easier. I'm easy either way.

Half talking out loud here: re backports. I think I'd like to backport this as far as possible (back to 1.9) and I know off the top of my head that its probably easier to do it manually, I'm guessing the backport bot won't be able to manage it. So I can do that separately.

Anyway let me know on the changelog thing, no probs if you don've have time, we can just go ahead and merge and I can do the 'paperwork'

@chinmaym07
Copy link
Contributor Author

Hey @johncowen . thankyou for testing this .
I can add the changelog.
Do I need to follow this to add a changelog entry.?

@johncowen
Copy link
Contributor

Yeah exactly 👍 , also if it helps take a look at any other theme/ui labelled closed PR (that don't have a no-changelog label).

Signed-off-by: chinmaym07 <[email protected]>
@johncowen
Copy link
Contributor

Screenshot 2022-03-07 at 17 56 35

@evrowe evrowe merged commit b934017 into hashicorp:main Mar 7, 2022
@chinmaym07 chinmaym07 deleted the ui/feature/add-tags-tab-to-gateways branch March 7, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Tags" tab to gateways (just like exists for non-gateway services)
4 participants