Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename partition-exports to exported-services #11739

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Rename partition-exports to exported-services #11739

merged 4 commits into from
Dec 6, 2021

Conversation

freddygv
Copy link
Contributor

@freddygv freddygv commented Dec 4, 2021

Using a name less tied to partitions gives us more flexibility to use
this config entry in OSS for exports between datacenters/meshes.

We also leave the door open for developers to be able to export
individual services with a "service-export" config entry.

@freddygv
Rename partition-exports to exported-services
ed6076d 
Using a name less tied to partitions gives us more flexibility to use
this config entry in OSS for exports between datacenters/meshes.
@freddygv
Move exported-services docs based on new name
09cdeae
@freddygv freddygv requested a review from a team December 4, 2021 00:49
@freddygv freddygv requested a review from a team as a code owner December 4, 2021 00:49
@github-actions github-actions bot added theme/acls ACL and token generation theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified labels Dec 4, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 4, 2021 00:50 Inactive
@vercel vercel bot temporarily deployed to Preview – consul December 4, 2021 00:50 Inactive
markan
markan reviewed Dec 4, 2021
View reviewed changes
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't see an update to the Website content for partition exports; should that be changed as well? Also a few minor comment updates.

markan
markan suggested changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't see an update to the Website content for partition exports; should that be changed as well? Also a few minor comment updates.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging December 4, 2021 22:16 Inactive
@freddygv freddygv requested a review from markan December 4, 2021 22:20
@freddygv freddygv merged commit a725f06 into main Dec 6, 2021
@freddygv freddygv deleted the ap/exports-rename branch December 6, 2021 15:20
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/518329.

@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/523348.

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit a725f06 onto stable-website failed! Build Log

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit a725f06 onto release/1.11.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markan markan markan approved these changes

@kisunji kisunji kisunji approved these changes

Assignees
No one assigned
Labels
theme/acls ACL and token generation theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freddygv @hashicorp-ci @hc-github-team-consul-core @markan @kisunji