Improved performance of the version.GetHumanVersion function by 50% on memory allocation.

[haxandmat]

Improved performance and added benchmark for func version.GetHumanVersion.

Instructions:

$ go install golang.org/x/perf/cmd/benchstat@latest

$ go test -bench=GetHumanVersion -count 5 -benchmem ./version > old.txt
$ go test -bench=GetHumanVersion -count 5 -benchmem ./version > new.txt

$ benchstat old.txt new.txt

Results

name               old time/op    new time/op    delta
GetHumanVersion-8     177ns ± 2%      80ns ± 3%  -54.53%  (p=0.008 n=5+5)

name               old alloc/op   new alloc/op   delta
GetHumanVersion-8     32.0B ± 0%     16.0B ± 0%  -50.00%  (p=0.008 n=5+5)

name               old allocs/op  new allocs/op  delta
GetHumanVersion-8      3.00 ± 0%      2.00 ± 0%  -33.33%  (p=0.008 n=5+5)

[eculver]

LGTM!

[eculver]

We're a little surprised that, because there's no assignment here, the compiler doesn't do some optimizations but looks good.

[eculver]

I'm not sure why this is still stuck but without the report back from CircleCI and without a new commit, it's just going to stay stuck. I tested this locally so I don't see any harm in just merging it so that's what I'll do :)

[hc-github-team-consul-core]

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/522907.